fix mockanalyzer to not use asserts [LUCENE-6127]

[asfimport]

Currently MockAnalyzer's checks are implemented with assert. But this is just for convenience, we should not rely upon asserts being turned on: this is the whole point of the class.

---

Migrated from LUCENE-6127 by Robert Muir (@rmuir)
Attachments: LUCENE-6127.patch

[asfimport]

Robert Muir (@rmuir) (migrated from JIRA)

Here is a first stab. Tests pass.

[asfimport]

Michael McCandless (@mikemccand) (migrated from JIRA)

+1

Thank you for fixing TestCachingTokenFilter to be more precise in its check for an exception.

[asfimport]

David Smiley (@dsmiley) (migrated from JIRA)

+1 Nice.

[asfimport]

ASF subversion and git services (migrated from JIRA)

Commit 1646878 from @rmuir in branch 'dev/trunk'
https://svn.apache.org/r1646878

LUCENE-6127: fix mockanalyzer to not use asserts

[asfimport]

ASF subversion and git services (migrated from JIRA)

Commit 1646890 from @rmuir in branch 'dev/branches/branch_5x'
https://svn.apache.org/r1646890

LUCENE-6127: fix mockanalyzer to not use asserts