Move LatLonShape and XYShape out of sandbox [LUCENE-8621]

[asfimport]

LatLonShape has matured a lot over the last months, I'd like to start thinking about moving it out of sandbox so that it doesn't stay there for too long like what happened to LatLonPoint. I am pretty happy with the current encoding. To my knowledge, we might just need to do a minor modification because of
#9666.

XYShape and foundation classes will also need to be refactored.

---

Migrated from LUCENE-8621 by Adrien Grand (@jpountz), updated Jan 22 2020
Linked issues:

• Remove the spatial module as it is obsolete [LUCENE-8369] #9416

[asfimport]

Michael McCandless (@mikemccand) (migrated from JIRA)

+1

[asfimport]

Nick Knize (@nknize) (migrated from JIRA)

+1

I can take this one. I vote:

1. Move LatLonShape to core as a companion to LatLonPoint
2. In a separate issue, refactor (or remove where appropriate) the two remaining classes ( GeoRelationUtils && MortonEncoder ) from the spatial module to either the core or spatial-extras module
3. Remove the spatial module 

 We can do the refactor for 8.0 and keep it in sandbox for 7.7 leaving the 7.x line consistent?

 

[asfimport]

David Smiley (@dsmiley) (migrated from JIRA)

BTW I already filed an issue to remove the spatial module and worked on it including a patch but @jpountz wasn't sure about that since it seemed LatLonShape would wind up there: https://issues.apache.org/jira/browse/LUCENE-8369?focusedCommentId=16525475&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16525475

While I'm a fan of having either no spatial or simple spatial in lucene-core, I'm also in favor of simplifying the user experience by reducing the number of places they will find spatial stuff. Balancing the two, and given the slippery slope of spatial already in lucene-core, I think it's best to remove the spatial module and put LatLonShape into core.

[asfimport]

Nick Knize (@nknize) (migrated from JIRA)

Ah. Thank you @dsmiley   I had forgotten about that issue.

+1 for the removal to be done for 8.0

[asfimport]

Nick Knize (@nknize) (migrated from JIRA)

Per #9416 I'll take the task of refactoring LatLonShape, XYShape, and all foundation, utility, and query classes

[asfimport]

ASF subversion and git services (migrated from JIRA)

Commit aad849b in lucene-solr's branch refs/heads/master from Nicholas Knize
https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=aad849b

LUCENE-8621: Refactor LatLonShape, XYShape, and all query and utility classes from sandbox to core

[asfimport]

ASF subversion and git services (migrated from JIRA)

Commit bd1bf55 in lucene-solr's branch refs/heads/branch_8x from Nicholas Knize
https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=bd1bf55

LUCENE-8621: Refactor LatLonShape, XYShape, and all query and utility classes from sandbox to core