[nocommit] LUCENE-9948: Automatically detect multi- vs. single-valued cases in LongValueFacetCounts#122
Merged
rmuir merged 4 commits intoapache:mainfrom May 3, 2021
Merged
Conversation
rmuir
approved these changes
May 3, 2021
Member
rmuir
left a comment
There was a problem hiding this comment.
looks good. thanks for cleaning up the api here.
Member
|
one TODO i want to try for fun, is to look at output from |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Automatically detect single- vs. multi-value cases instead of asking the user to specify.
Solution
Use DocValues helper methods to automatically determine the underlying field type.
Tests
No new tests but modified existing to no longer require the multiValued ctor parameter, and ensured they cover both the single- and multi-valued cases.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.