Add per-field knn vector format info in SegmentInfo#13367
Closed
tteofili wants to merge 4 commits intoapache:mainfrom
Closed
Add per-field knn vector format info in SegmentInfo#13367tteofili wants to merge 4 commits intoapache:mainfrom
tteofili wants to merge 4 commits intoapache:mainfrom
Conversation
Contributor
|
I'm a bit confused: what is the benefit of having it on segment infos in addition to field infos? |
Contributor
Author
|
you're right @jpountz , we can probably get away with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When indexing vectors, it is possible to use different vector formats depending on the field; in addition to that it's also possible (although not currently implemented) to have
Codecsthat can provide different vector formats "dynamically" even for a same field.To better debug such situations, it would be helpful to have per field vector format information within
SegmentCommitInfo(e.g. within theattributes).This trivial PR adds
KnnVectorFormat#namefor each field toSegmentInfo#attributesinPerFieldKnnVectorsFormat.If a doc with
field1is indexed withLucene99HnswVectorsFormatand a doc withfield2is indexed withLucene99HnswScalarQuantizedVectorsFormatwithin the same segment, the correspondingSegmentInfo#attributeswill have the following entries:"KnnVectorFormat.field1"->"Lucene99HnswVectorsFormat""KnnVectorFormat.field2"->"Lucene99HnswScalarQuantizedVectorsFormat"