Reduce the compiled size of the collect() method on TopScoreDocCollector.
#13939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor`. This comes from observations on https://tantivy-search.github.io/bench/ for exhaustive evaluation like `TOP_100_COUNT`. `collect()` is often inlined, but other methods that we'd like to see inlined like `PostingsEnum#nextDoc()` are not always inlined. This PR decreases the compiled size of `collect()` to make more room for other methods to be inlined. It does so by moving an assertion to `AssertingScorable` and extracting an uncommon code path to a method.
Contributor
Author
|
For reference, luceneutil shows no difference. |
original-brownbear
approved these changes
Oct 21, 2024
Member
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, I think this makes sense. The benchmarks tend to show collectCompetitiveHit as a cold path and in fact on one of my benchmarking machines (faster Threadripper), I get a slight reproducible win for TermDTSort which afaik is one of the tasks that exercise this logic the hardest. No such win on a weaker i7 with less cache, but maybe we can take that as an indication that we can push this further by making other code smaller :)
jpountz
deleted the
reduce_compiled_size_of_top_score_doc_collector_collect
branch
jpountz
added a commit
that referenced
this pull request
Oct 22, 2024
…ctor`. (#13939) This comes from observations on https://tantivy-search.github.io/bench/ for exhaustive evaluation like `TOP_100_COUNT`. `collect()` is often inlined, but other methods that we'd like to see inlined like `PostingsEnum#nextDoc()` are not always inlined. This PR decreases the compiled size of `collect()` to make more room for other methods to be inlined. It does so by moving an assertion to `AssertingScorable` and extracting an uncommon code path to a method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from observations on https://tantivy-search.github.io/bench/ for exhaustive evaluation like
TOP_100_COUNT.collect()is often inlined, but other methods that we'd like to see inlined likePostingsEnum#nextDoc()are not always inlined. This PR decreases the compiled size ofcollect()to make more room for other methods to be inlined.It does so by moving an assertion to
AssertingScorableand extracting an uncommon code path to a method.