Skip to content

Conversation

@benwtrent
Copy link
Member

I have noticed some additional flakiness for knn recall.

For example:

./gradlew test --tests TestPerFieldKnnVectorsFormat.testRecall -Dtests.seed=FAEFE5196FDED25B -Dtests.locale=twq-Latn-NE -Dtests.timezone=America/New_York -Dtests.asserts=true -Dtests.file.encoding=UTF-8

So, I am making two minor adjustments to the test:

  • Increasing hnsw efsearch to 25 (still only gathering 10 nearest docs in the end)
  • Better filling vectors for tiny lines

I also added some nicer toString methods and output for the test, so if we notice it failing again, we can quickly see for what codec and options.

@benwtrent benwtrent added this to the 10.2.0 milestone Feb 20, 2025
Copy link
Contributor

@msokolov msokolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @benwtrent !

@benwtrent benwtrent merged commit 5491c94 into apache:main Feb 21, 2025
6 checks passed
@benwtrent benwtrent deleted the test/address-knn-recall-flakiness branch February 21, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants