Skip to content

Fix for changelog verifier and milestone setter automation #14369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pseudo-nymous wants to merge 2 commits into from
Closed

Fix for changelog verifier and milestone setter automation #14369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99908a2
Fix for changelog verifier and milestone setter automation
pseudo-nymous Mar 19, 2025
390dabd
revert for using head.ref instead of head.sha
pseudo-nymous Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/verify-changelog-and-set-milestone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ jobs:
echo -e "\n"
echo "################## STEP 2 ##################"
echo "Checking for change log entry in ${{ env.CHANGE_LOG_FILE }}"
git fetch origin ${{ github.event.pull_request.base.ref }}
git log --pretty=oneline | tail -n 2 | cat
echo "merge base sha: ${{ github.event.pull_request.base.sha }}, merge head sha: ${{ github.event.pull_request.head.sha }}"
git pull --unshallow origin ${{ github.event.pull_request.head.ref }}
git log --pretty=oneline | head -n 25 | cat
echo "merge base ref: ${{ github.event.pull_request.base.ref }}, head ref: ${{ github.event.pull_request.head.ref }}"
echo "merge base sha: ${{ github.event.pull_request.base.sha }}, head sha: ${{ github.event.pull_request.head.sha }}"
if ! git diff ${{ github.event.pull_request.base.sha }} --name-only | grep -q "${{ env.CHANGE_LOG_FILE }}"; then
echo "Change log file:${{ env.CHANGE_LOG_FILE }} does not contains an entry corresponding to changes introduced in PR. Please add a changelog entry."
exit 0
Expand Down