LUCENE-9454: Remove version field on Analyzer#154
Merged
romseygeek merged 2 commits intoapache:mainfrom May 26, 2021
Merged
Conversation
mikemccand
approved these changes
May 26, 2021
Member
mikemccand
left a comment
mikemccand
left a comment
There was a problem hiding this comment.
+1, this is 9.0 only?
This was an overly complex approach to backwards compatibility!
Contributor
Author
Yes, I should have made that clear, sorry! |
Contributor
|
@mikemccand I'm curious why you say:
I think it's rather simple, and the PR was simple as well showing it was a simple idea. If this approach is complex, what simple approach do you recommend instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version switching on Analyzer behaviour should be implemented
in the various component factories, rather than on a mutable
setting on Analyzer itself.