Add validation to prevent zero vectors in KNN fields #15621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have checks to disallow zero vectors from getting indexed today. This becomes a problem later when vectors are searched or segments are merged, as noted in #15540. This change prevents zero vectors from getting indexed.
AI Disclosure: The change itself is trivial but it broke quite a few tests. I fixed about half of them manually, then leveraged AI to fix remaining tests. I've reviewed all AI test fixes. Most of them were simply replacing zero/empty vectors with non-empty vector values. Some tests checked for vector similarity scores, and I've fixed them accordingly.
Addresses #15540