Skip to content

Bring new quantized format inline with old quantized format #15622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benwtrent merged 2 commits into from
Jan 28, 2026
Merged

Bring new quantized format inline with old quantized format #15622

benwtrent merged 2 commits into from
Jan 28, 2026
+21 −5

Conversation

@benwtrent
Copy link
Member

@benwtrent benwtrent commented Jan 27, 2026

There were various APIs that the old scalar quantization format satisfied that the new failed to do. This corrects that oversight.

  • HasSlice
  • Correctly setting the byte length for vectors
  • Ensuring scorer is injectable (composable format stuff, just like older format)
  • Making sure access to the byte vectors is possible

@benwtrent benwtrent added this to the 10.4.0 milestone Jan 27, 2026
@benwtrent benwtrent added the skip-changelog Apply to PRs that don't need a changelog entry, stopping the automated changelog check. label Jan 27, 2026
jimczi
jimczi approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tteofili
tteofili approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@tteofili tteofili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 849ce20 into apache:main Jan 28, 2026
12 checks passed
benwtrent added a commit that referenced this pull request Jan 28, 2026
@benwtrent
Bring new quantized format inline with old quantized format (#15622)
fab6267 
* Bring new quantized format inline with old quantized format

* iter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tteofili tteofili tteofili approved these changes

@jimczi jimczi jimczi approved these changes

Assignees

No one assigned

Labels

module:core/codecs skip-changelog Apply to PRs that don't need a changelog entry, stopping the automated changelog check.

Projects

None yet

Milestone

10.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@benwtrent @tteofili @jimczi