Conversation
Reformat all the files, remove the exclusion. Also fix a bug in the check, so it will still fail if there are markdown problems that couldn't automatically be fixed. Most problems are autofixed without manual effort.
rmuir
added
the
skip-changelog
This comment was marked as outdated.
This comment was marked as outdated.
The default is a 2-space indent, but editorconfig says 4. Make these consistent so there is the least friction for developers.
uschindler
approved these changes
Feb 1, 2026
Contributor
uschindler
left a comment
uschindler
left a comment
There was a problem hiding this comment.
Looks fine! The explicit <> around links is not really needed in our case, but of course it is good style. The Markdown-Converters we use are Github style and detect links automatically. We could disable this in out gradle scripts that build the documentation:
finnroblin
pushed a commit
to finnroblin/lucene
that referenced
this pull request
Feb 2, 2026
* docs: reformat markdown Reformat all the files, remove the exclusion. Also fix a bug in the check, so it will still fail if there are markdown problems that couldn't automatically be fixed. Most problems are autofixed without manual effort. * build: fix rumdl configuration to match editorconfig (indent=4) The default is a 2-space indent, but editorconfig says 4. Make these consistent so there is the least friction for developers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reformat all the files, remove the exclusion.
Also fix a bug in the check, so it will still fail if there are markdown problems that couldn't automatically be fixed. Most problems are autofixed without manual effort.
Followup to #15629