Skip to content

Revert "Optimize DocIdSetIteratorAcceptDocs#cost (#15592)"#15687

Merged
benwtrent merged 1 commit intoapache:mainfrom
benwtrent:bugfixfix-vector-search-cost
Feb 9, 2026
Merged

Revert "Optimize DocIdSetIteratorAcceptDocs#cost (#15592)"#15687
benwtrent merged 1 commit intoapache:mainfrom
benwtrent:bugfixfix-vector-search-cost

Conversation

@benwtrent
Copy link
Member

@shubhamvishu sorry for the revert :(. I ran into some weird test failures and it turns out (unsurprisingly) mutating the behavior of cost depending on if some other method was called is a pretty rough API.

For now, I am going to revert, and I will likely have to rebuild another RC for 10.4.

I think if we are going to do this, we need a cost and an approximateCost API. Where approximateCost can change, but cost is when we want the real cost :(

@benwtrent benwtrent added this to the 10.4.0 milestone Feb 9, 2026
@benwtrent
Copy link
Member Author

The specific failure is that when we do cost checking in the HNSW format, sometimes we check before the idset is created and other times after. Which pretty much breaks downstream search logic that depends on accurate costs.

@benwtrent benwtrent merged commit d05c246 into apache:main Feb 9, 2026
13 checks passed
@benwtrent benwtrent deleted the bugfixfix-vector-search-cost branch February 9, 2026 22:20
benwtrent added a commit that referenced this pull request Feb 9, 2026
benwtrent added a commit that referenced this pull request Feb 9, 2026
@shubhamvishu
Copy link
Contributor

Thanks @benwtrent for identification and reverting the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants