Revert "Optimize DocIdSetIteratorAcceptDocs#cost (#15592)"#15687
Merged
benwtrent merged 1 commit intoapache:mainfrom Feb 9, 2026
Merged
Revert "Optimize DocIdSetIteratorAcceptDocs#cost (#15592)"#15687benwtrent merged 1 commit intoapache:mainfrom
benwtrent merged 1 commit intoapache:mainfrom
Conversation
This reverts commit 2f9aa8a.
Member
Author
|
The specific failure is that when we do |
benwtrent
added a commit
that referenced
this pull request
Feb 9, 2026
benwtrent
added a commit
that referenced
this pull request
Feb 9, 2026
Contributor
|
Thanks @benwtrent for identification and reverting the change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@shubhamvishu sorry for the revert :(. I ran into some weird test failures and it turns out (unsurprisingly) mutating the behavior of cost depending on if some other method was called is a pretty rough API.
For now, I am going to revert, and I will likely have to rebuild another RC for 10.4.
I think if we are going to do this, we need a
costand anapproximateCostAPI. WhereapproximateCostcan change, butcostis when we want the real cost :(