Fix LuceneTestCase to always use passed random parameter where possible#15725
Merged
rmuir merged 1 commit intoapache:mainfrom Feb 19, 2026
Merged
Conversation
rmuir
approved these changes
Feb 19, 2026
rmuir
added
the
skip-changelog
gmarouli
pushed a commit
to gmarouli/lucene
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LuceneTestCasehas quite a few methods that allow passing aRandomparameter. In a few of those methods that passed parameter is not used, but the standardrandom()supplier is called - or usages mixed between the argument and the standardrandom()call.While this change seems useful to me from a code perspective, it might also mean, that trying to repeat currently failing test runs might pass with this. Please just go ahead and close if you think it's not worth it.
I also renamed the
configureRandommethod, because it was not clear to me what it's doing.