Simplify TermCounts#sortedTermCounts in luke module#15834
Open
gaobinlong wants to merge 1 commit intoapache:mainfrom
Open
Simplify TermCounts#sortedTermCounts in luke module#15834gaobinlong wants to merge 1 commit intoapache:mainfrom
gaobinlong wants to merge 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When addressing issues in luke module, found that the TermCounts#sortedTermCounts method can be simplified, so this pr changes switch...case to a modern switch expression, and removes the redundant
defaultbranch since all enum constants are covered(this also improves safety because an compiler error will be thrown once new enum constant is added into TermCountsOrder).