Use IllegalCallerException to signal wrong caller in internal classes (VectorizationProvider, TestSecrets)#15877
Merged
Conversation
… (VectorizationProvider, TestSecrets) + cleanup code a bit
Contributor
Author
|
This will be backported, because we changed the exceptions anyways (some were AssertionFailed, now UnsupportedOperationEx). This makes it clear: "you're not allowed to call a method". It wont break backwards, as code should not call those methods anyways. |
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Mar 25, 2026
… (VectorizationProvider, TestSecrets) (#15877) + cleanup code a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split this from #15867, see other PR for background (thanks @danmuzi).
This basically only changes the exception for VectorizationProvider and TestSecrets if the method is called by wrong calle (outside test framework or known classes). It also refactors the code from #15864 a bit to have only one method throwing the exception.