Optimize GroupFacetCollector.getFacetEntries()#15947
Open
gaobinlong wants to merge 3 commits intoapache:mainfrom
Open
Optimize GroupFacetCollector.getFacetEntries()#15947gaobinlong wants to merge 3 commits intoapache:mainfrom
gaobinlong wants to merge 3 commits intoapache:mainfrom
Conversation
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
dweiss
reviewed
Apr 11, 2026
Contributor
dweiss
left a comment
There was a problem hiding this comment.
In all honesty, I think the previous version was easier to understand and the gain is probably minimal (if at all detectable)?
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Contributor
Author
|
Thanks @dweiss , I reverted some change but kept the change of initial ArrayList with known size and return empty ArrayList if offset >= total size, are these also not necessary? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The method GroupFacetCollector.getFacetEntries() can be optimized by:
included, use entries.size() instead.