Create context per collector in TestAllGroupsCollector.createRandomCollectorManager#16094
Merged
Conversation
…llectorManager Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Contributor
Author
javanna
approved these changes
May 21, 2026
Contributor
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
LGTM thanks a lot for coming back to this!
javanna
added
the
skip-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In TestAllGroupsCollector.createRandomCollectorManager, we create on context and make it be shared across collectors in concurrent search scenario, this is not thread-safe, need to create context for each collector.