Fix SortedSkipperScorerSupplier.cost() calculation#16096
Merged
Conversation
This fixes two issues: - SortedSkipperScorerSupplier.cost() could overestimate its value if the lower value of a range didn't align with a skipper block boundary. We only need to check the upper value for alignment, as if the lower value is not aligned the read cost will be lower than the calculation. - Tests for this were using the number of live docs to calculate the expected value but we also need to take into account docs added and then deleted. We also add some explicit tests for the cost calculation for various range and skip block configurations.
romseygeek
added
the
skip-changelog
romseygeek
added a commit
that referenced
this pull request
May 21, 2026
This fixes two issues: - SortedSkipperScorerSupplier.cost() could overestimate its value if the lower value of a range didn't align with a skipper block boundary. We only need to check the upper value for alignment, as if the lower value is not aligned the read cost will be lower than the calculation. - Tests for this were using the number of live docs to calculate the expected value but we also need to take into account docs added and then deleted. We also add some explicit tests for the cost calculation for various range and skip block configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
We also add some explicit tests for the cost calculation for various range and skip block configurations.