Validate zero vectors in setVectorValue() for cosine similarity fields#16098
Open
iprithv wants to merge 1 commit into
Open
Validate zero vectors in setVectorValue() for cosine similarity fields#16098iprithv wants to merge 1 commit into
iprithv wants to merge 1 commit into
Conversation
iprithv
force-pushed
the
fix-zero-vector-setvalue
branch
2 times, most recently
from
0b76047 to
7831c43
Compare
iprithv
force-pushed
the
fix-zero-vector-setvalue
branch
from
7831c43 to
9861923
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #15751 added zero-vector validation in KnnByteVectorField and KnnFloatVectorField constructors when cosine similarity is configured. However, setVectorValue() was not covered, allowing users to bypass the check by creating a field with a valid vector and then mutating it to a zero vector. This can still lead to the same MergeAbortedException / CheckIndex failures described in #15540.