Make HNSW graph building and CheckIndex resilient to zero vectors with cosine similarity#16099
Open
iprithv wants to merge 1 commit into
Open
Make HNSW graph building and CheckIndex resilient to zero vectors with cosine similarity#16099iprithv wants to merge 1 commit into
iprithv wants to merge 1 commit into
Conversation
iprithv
force-pushed
the
fix-hnsw-zero-vector-resilience
branch
from
c436b0e to
dcad7e2
Compare
…h cosine similarity
iprithv
force-pushed
the
fix-hnsw-zero-vector-resilience
branch
from
dcad7e2 to
33d9b1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #15751 prevents new zero vectors from being indexed, but existing indexes with zero vectors still crash during merge (assertion failure in NeighborArray.addInOrder) and CheckIndex (CheckIndexException on zero search results). so fixed it!
Relates to #15540