Invert eligible BinaryColumns in the column pass#16116
Draft
Tim-Brooks wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BinaryColumns that are DOCS or DOCS_AND_FREQS, omitNorms, no TVs, and
not stored are now inverted directly in the column-oriented pass via
processBinaryColumnInvert, walking each column's cursor sparsely. When
any row-mode column is present in the batch, eligible columns are
demoted to the row pass so all inverted fields share a single
termsHash frame per doc.
processBinaryColumnInvert skips termsHash.startDocument/finishDocument:
those drive TermVectorsConsumer's segment-scoped lastDocID, and framing
the same batch doc from multiple eligible columns would break its
monotonicity invariant. Eligibility guarantees doVectors=false, so TV
state is never touched; unframed docs are reconciled by
TermVectorsConsumer.fill(). Exception handling mirrors processDocument:
pf.finish runs only if the first pf.invert returned normally.
The validation pass caches each column's PerField in docFields[] by
original column position; the row pass tracks original indices in
rowPfIndices[] instead of overwriting docFields[], so both passes can
reuse the cache without a second hash lookup.