Remove getOrAddPerField calls in processBatch#16118
Merged
Merged
Conversation
The schema-validation pass in processBatch already resolves a PerField for every column via getOrAddPerField. The row-oriented and column-oriented passes were each re-resolving the same PerField by name, costing two extra hash lookups per column per batch. Cache the validated PerField into docFields[] keyed by the column's original position, and have both downstream passes read from that cache. processRowColumns now keeps a local int[] rowPfIndices mapping row-mode slots back to their original column position, so the inner loop can index docFields[] directly. docFields is grown in the validation pass instead of inside processRowColumns.
ChrisHegarty
pushed a commit
that referenced
this pull request
May 25, 2026
The schema-validation pass in processBatch already resolves a PerField for every column via getOrAddPerField. The row-oriented and column-oriented passes were each re-resolving the same PerField by name, costing two extra hash lookups per column per batch. Cache the validated PerField into docFields[] keyed by the column's original position, and have both downstream passes read from that cache. processRowColumns now keeps a local int[] rowPfIndices mapping row-mode slots back to their original column position, so the inner loop can index docFields[] directly. docFields is grown in the validation pass instead of inside processRowColumns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema-validation pass in processBatch already resolves a PerField
for every column via getOrAddPerField. The row-oriented and
column-oriented passes were each re-resolving the same PerField by name,
costing two extra hash lookups per column per batch.
Cache the validated PerField into docFields[] keyed by the column's
original position, and have both downstream passes read from that
cache. processRowColumns now keeps a local int[] rowPfIndices mapping
row-mode slots back to their original column position, so the inner
loop can index docFields[] directly. docFields is grown in the
validation pass instead of inside processRowColumns.