Remove deprecated usages of search(Query, Collector) from monitor module#16197
Open
javanna wants to merge 1 commit into
Open
Remove deprecated usages of search(Query, Collector) from monitor module#16197javanna wants to merge 1 commit into
javanna wants to merge 1 commit into
Conversation
This is merely removing the deprecated usages, without introducing search concurrency to monitor. The searcher creation is all internal to monitor and there is currently no way for users to provide an executor to parallelize searches. Should we want to do that in the future, a larger refactor is needed to support inter-segment concurrency.
javanna
added
module:monitor
skip-changelog
14 tasks
| searcher.search(query, collector); | ||
| searcher.search( | ||
| query, | ||
| new CollectorManager<LazyMonitorQueryCollector, Void>() { |
Contributor
There was a problem hiding this comment.
I see that it's common across the two files, worth putting in one place?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is merely removing the deprecated usages, without introducing search concurrency to monitor.
The searcher creation is all internal to monitor and there is currently no way for users to provide an executor to parallelize searches. Should we want to do that in the future, a larger refactor is needed to support inter-segment concurrency.
Created #16198 to follow-up on introducing search concurrency for monitor.