Lazily allocate DocAndScoreAccBuffer in MaxScoreBulkScorer#16316
Conversation
This buffer is only used in certain code paths, so allocation in the constructor adds unnecessary costs.
|
thanks for the fix, @romseygeek. |
|
No worries @iprithv, this didn't get picked up in any of the nightly benchmarks and it only really effects some corner cases (like elasticsearch's percolator) that ought to be disabling bulk scoring in any case. I think this is probably still worth doing to make things slightly more efficient when we use the other code paths, but it isn't a serious regression. I'll put it into 10.6 |
This buffer is only used in certain code paths, so allocation in the constructor adds unnecessary costs.
This buffer is only used in certain code paths, so allocation in the constructor adds unnecessary costs.