LUCENE-10101: Use getField() instead of getDeclaredField() to minimize security impact by analysis SPI discovery#298
Merged
Conversation
…e security impact by analysis SPI discovery
romseygeek
approved these changes
Sep 14, 2021
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, thanks @uschindler! cc @rjernst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before creating a pull request, please file an issue in the ASF Jira system for Lucene:
Description
This PR changes the AnalyisSPILoader's method to lookup the
NAMEfield of the SPI to useClass#getField()instead ofClass#getDeclaredField(). This does not require special security privileges if the class is in a related classloader. AsgetField()unfortunately also looks into superclass if the field is not found, the checks for validness of the field have to be changed to check the declaring class. In contrast, the public check is obsolete, as only public fields are returned.Tests
Testing is hard, as our security policy of tests allows to do declared member access. So no test will be added. Testing will be done by Elasticsearch people (@romseygeek).
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.