LUCENE-10262: Lift up restrictions for navigating PointValues#PointTree#476
Merged
Conversation
jpountz
approved these changes
Nov 25, 2021
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
It makes the API much easier to use!
| // move position of the inner nodes index in case we move to the first child | ||
| assert readNodeDataPositions[level] < innerNodes.getFilePointer(); | ||
| innerNodes.seek(readNodeDataPositions[level]); | ||
| } |
Contributor
There was a problem hiding this comment.
seek should be cheap, I wonder if we could call it resetNodeDataPosition() and change the impl to call seek unconditionally?
Contributor
Author
There was a problem hiding this comment.
yes, quick check and it makes no difference.
| addOneByOne(visitor); | ||
| } | ||
|
|
||
| public void addOneByOne(PointValues.IntersectVisitor visitor) throws IOException { |
Contributor
There was a problem hiding this comment.
Maybe give it a more explicit name, e.g. visitLeavesOneByOne?
jpountz
approved these changes
Nov 25, 2021
iverase
added a commit
that referenced
this pull request
Nov 26, 2021
…ee (#476) This change allows random navigation of a PointValues#PointTree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://issues.apache.org/jira/browse/LUCENE-10262