Fix gradle task name conflict ('run' to 'runLuke')#479
Closed
mocobeta wants to merge 1 commit intoapache:mainfrom
Closed
Fix gradle task name conflict ('run' to 'runLuke')#479mocobeta wants to merge 1 commit intoapache:mainfrom
mocobeta wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
This is not a bug, actually. If you run gradlew run, it'll run that task in all of the submodules that contain it. You should scope the invocation: gradlew :lucene:luke:run or gradlew -p lucene/luke run. I don't think these have to be made unique (a description of the 'run' task should be added to benchmarks). |
Contributor
Author
|
Yes, I've always run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two Gradle tasks named "run": the one is defined in the "benchmark" project, and another one is in the "luke" project.
gradlew tasksshows:When I run
gradlew run, this actually invokes theruntask that belongs to "benchmark" (and fails).This quick-fix resolves the naming conflict. There could be a proper way to handle such conflicts, though.
To avoid a too generic name for each task seems to be a good practice.
https://discuss.gradle.org/t/what-occur-on-a-task-name-conflict/11693