LUCENE-10321: Tweak MultiRangeQuery interval tree creation logic#547
Merged
gsmiller merged 3 commits intoapache:mainfrom Dec 17, 2021
Merged
LUCENE-10321: Tweak MultiRangeQuery interval tree creation logic#547gsmiller merged 3 commits intoapache:mainfrom
gsmiller merged 3 commits intoapache:mainfrom
Conversation
iverase
requested changes
Dec 16, 2021
Contributor
There was a problem hiding this comment.
I would prefer if RangeTree does not implement Range any more as it does not follow the contract. What do you think?
hold on - I think I have another thing in mind :)
So I was thinking we can remove this part as well:
Then creating the tree should be pretty cheap.
Contributor
Author
+1 makes sense
Yeah, good catch! I think my new revision addresses both of these suggestions. Thanks for the quick feedback! |
iverase
approved these changes
Dec 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small tweak that makes the interval tree creation logic in MultiRangeQuery consistent with ComponentTree.
Solution
Just remove the "roll up" of min values since internal node bounding boxes don't need consistent min values.
Tests
All existing tests continue to pass.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.