Skip to content

trivial updates on github actions#674

Merged
mocobeta merged 1 commit intoapache:mainfrom
mocobeta:small-change-gh-actions
Feb 10, 2022
Merged

trivial updates on github actions#674
mocobeta merged 1 commit intoapache:mainfrom
mocobeta:small-change-gh-actions

Conversation

@mocobeta
Copy link
Copy Markdown
Contributor

@mocobeta mocobeta commented Feb 10, 2022

  • upgrade actions/setup-java to v2 in the hunspell regression workflow (aligned with the main workflow)
  • migrate the distribution to 'temurin' (recommended in supported distributions)

@mocobeta
Copy link
Copy Markdown
Contributor Author

Do you have a minute to take a look? @dweiss

@dweiss
Copy link
Copy Markdown
Contributor

dweiss commented Feb 10, 2022

It'd be interesting to randomize those distributions using a custom action, perhaps? I have no experience here whatsoever, but I bet it's possible...

@mocobeta
Copy link
Copy Markdown
Contributor Author

Thank you, I will merge this soon.

It'd be interesting to randomize those distributions using a custom action, perhaps? I have no experience here whatsoever, but I bet it's possible...

I have never tried writing such a complex action, it could be implemented by some bash script. ? (I am not sure the Actions' sandbox gives users what level of flexibility.)

@mocobeta mocobeta merged commit 4cb55a7 into apache:main Feb 10, 2022
@mocobeta mocobeta deleted the small-change-gh-actions branch February 10, 2022 16:13
@dweiss
Copy link
Copy Markdown
Contributor

dweiss commented Feb 10, 2022

I think these actions are javascript, basically. I've never written one myself, so can't help. Don't worry about it, it was just a wild idea - we have lots of randomization elsewhere.

@mocobeta
Copy link
Copy Markdown
Contributor Author

I am not sure if randomizing the distribution per test run is possible without forking the setup-java action, but I think a matrix test may be easy (if it makes sense to run workflows for multiple distributions on every PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants