Removing/limiting uses of static variables and methods in Testcases #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.LastDoc = lastDoc; | ||
| this.LastReader = lastReader; | ||
| this.Context = context; | ||
| NewSearcher = newSearcher; |
Contributor
There was a problem hiding this comment.
NewSearcherFunc would be a more appropriate name I think?
Contributor
|
Thanks @conniey , looks good! I left a few comments - the main idea is to minimize the amount of non-Java compatible changes we make and to document well the ones we have to make. |
Contributor
Author
|
Closing this PR because I created an improved one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would allow an easier transition to using xUnit. xUnit by default, runs its tests in parallel and asynchronously. The current use of mutable static fields limits in test cases the ability to utilise this.
OLD_FORMAT_IMPERSONATION_IS_ACTIVEto non-static field since other tests share and use this variableClassEnvRuleto non-static since every test class generates its own rule during test