Skip to content

Classification tests#27

Merged
asfgit merged 3 commits intoapache:masterfrom
laimis:classification_tests
Dec 24, 2014
Merged

Classification tests#27
asfgit merged 3 commits intoapache:masterfrom
laimis:classification_tests

Conversation

@laimis
Copy link
Contributor

@laimis laimis commented Dec 24, 2014

High level summary of changes:

  • ported another class in Classification which I had forgotten: Utils/DatasetSplitter
  • ported all the tests in Classification, 9 total: 7 pass, 1 fails, 1 ignore
  • failing test appears to fail for random reasons, something that I see in the other tests in core, will need to be addressed separately. The issue of the resources not getting cleaned up properly somewhere in core because if I run tests one by one they pass.
  • 1 ignored test in SimpleNaiveBayesClassifierTest called TestNGramUsage. Depends on EdgeNGramTokenFilter and other classes that are present in Lucene.Net.Analysis.Common but do not appear to be fully ported or ready to be integrated.
  • fixed a bug in the previously ported KNearestNeighborClassifier that the tests uncovered

@asfgit asfgit merged commit b5568a3 into apache:master Dec 24, 2014
@synhershko
Copy link
Contributor

Merged, thanks

@laimis laimis deleted the classification_tests branch December 27, 2014 19:04
konopka pushed a commit to konopka/lucenenet that referenced this pull request Jan 11, 2017
* Renamed hyphenation to Hyphenation to fix build and run on case sensitive file systems

* Analysis.Common.Compound: Fixed 10 test failures due to XmlReaderSettings not being passed to XmlReader.

* Analysis.Common.CharFilters: Fixed test failure due to missing embedded resource MS-Word14generated.htm

* Facet: Fixed bug in CharBlockArray that was causing 3 tests to fail on .NET Framework.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants