fixes for handling surrogate chars properly#36
Merged
asfgit merged 1 commit intoapache:masterfrom Dec 31, 2014
laimis:unicode_issues
Merged
fixes for handling surrogate chars properly#36asfgit merged 1 commit intoapache:masterfrom laimis:unicode_issues
asfgit merged 1 commit intoapache:masterfrom
laimis:unicode_issues
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestUTF32ToUTF8.TestRandomRanges were failing because of the issue with how the surrogate pairs were handled in Character class. Changed the implementation to call UnicodeUtils to provide correct ToChars implementation. Now the test passes.
Added method to UnicodeUtil to provide public API for converting code points to strings and chars so that we don't have to do repeating conversion (char[] -> string -> char[]).