This repository was archived by the owner on May 12, 2021. It is now read-only.
Remove casting-away-const-ness#2
Closed
rectang wants to merge 2 commits intoapache:cfish-string-prep1from
Closed
Conversation
Method typedefs, like method invocation inline functions, are defined for each class in the inheritance chain. Prior to this fix, the "self" type in the typedef was the type of the last concrete implementor rather than the type of the invocant.
Method invocation functions have been casting away const-ness by accepting `const prefix_Foo *self` as the invocant but then invoking the retrieved function pointer with `self` cast to `(prefix_Foo*)`. This was necessary to avoid warnings from "const CharBuf" immutable strings -- but now our String type is immutable without requiring `const`, allowing us to improve type safety by removing the cast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we've migrated from
const CharBuf*throughconst String*tosimply
String*, this long-awaited change can be made.