This repository was archived by the owner on May 12, 2021. It is now read-only.
LUCY-282 Test Go bindings for Index compoments pt1#26
Merged
asfgit merged 14 commits intoapache:masterfrom Nov 7, 2015
Merged
Conversation
Treat empty String the same as NULL. Don't document "an assignment idiom" when returning the object, because the Go method binding returns a tuple of (Snapshot, error) and thus doesn't allow an assignment idiom.
asfgit
pushed a commit
that referenced
this pull request
Nov 7, 2015
Tune and and test the Go bindings for various "Index" components. The autogenerated Go bindings suffice for some of these classes, but many others require tweaking. The most common customizations relate to providing idiomatic error handling and subtyping slices. This closes #26.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tune and and test the Go bindings for various "Index" components.
The autogenerated Go bindings suffice for some of these classes, but many others require tweaking. The most common customizations relate to providing idiomatic error handling and subtyping slices.