This repository was archived by the owner on May 12, 2021. It is now read-only.
LUCY-295 Change I32Array to use size_t (v2)#39
Merged
asfgit merged 7 commits intoapache:masterfrom Apr 12, 2016
Merged
Conversation
Only the core module -- all usage sites need to be changed next.
Adapt these two very similar Query subclasses for the I32Array size change.
Add/remove casts for functions where the width of a size argument has changed.
These changes are a grab bag, some of which are easy to review and some of which are more subtle.
| int32_t i; | ||
| int64_t size = av_len(ints_av) + 1; | ||
| int32_t *ints; | ||
| int64_t i; |
Contributor
There was a problem hiding this comment.
I just realized that Perl switched from I32 to SSize_t for array sizes in 5.20. Ideally, we should add a typedef depending on the Perl version and use it for size and i. But this can be done later.
asfgit
pushed a commit
that referenced
this pull request
Apr 12, 2016
Change I32Array so that it uses a size_t to index into its array of 32-bit integers. This entails both changes to the class internals and to the internal API. (I32Array is not a public API.) This fixes #39.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change I32Array so that it uses a size_t to index into its array of 32-bit integers. This entails both changes to the class internals and to the internal API. (I32Array is not a public API.)
This pull requests adds one commit to fix the Go bindings compared to v1.