This repository was archived by the owner on May 12, 2021. It is now read-only.
Merged
Conversation
Have BitVector use a size_t to track its capacity and to index into the bit array.
Create a dedicated static function which given a bit size returns a byte size.
BitVector API functions now take size_t indexes rather than uint32_t.
Changing indexes from uint32_t to size_t requires updating a fair amount of test code.
BitVec counts and sizes are now measured in size_t not uint32_t.
Contributor
|
In the long run, I'd suggest to change the return value of |
| return SIZE_MAX / 8; | ||
| } | ||
| return (bit_size + 7) / 8; | ||
| } |
Contributor
There was a problem hiding this comment.
The overflow check should be:
if (bit_size > SIZE_MAX - 7) {
return SIZE_MAX / 8 + 1;
}
Or maybe an alternative implementation:
static CFISH_INLINE size_t
SI_octet_size(size_t bit_size) {
if (bit_size == 0) { return 0; }
return (bit_size - 1) / 8 + 1;
}
asfgit
pushed a commit
that referenced
this pull request
Apr 13, 2016
Change BitVector to use `size_t` instead of `uint32_t` to address bits in the array. This fixes #40.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change BitVector to use
size_tinstead ofuint32_tto address bits in the array.