This repository was archived by the owner on May 12, 2021. It is now read-only.
Merged
Conversation
The result being truncated will never be wider than 8 bits.
Both versions pass tests, but this doesn't make -Wconversion complain.
Change the tick (array index) parameter for 1-bit, 2-bit, and 4-bit integer array manipulation routines from uint32_t to size_t.
Make appropriate casts or other adjustments to avoid warnings with regards to NumUtil 1-bit, 2-bit and 4-bit integer array manipulation routines.
Contributor
|
Looks good. |
asfgit
pushed a commit
that referenced
this pull request
Apr 25, 2016
In NumberUtils.cfh: * Widen the array index type for addressing 1-bit, 2-bit, and 4-bit arrays. * Address a few (false positive) compiler warnings from `-Wconversion`. This fixes #43.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In NumberUtils.cfh:
-Wconversion.