This repository was archived by the owner on May 12, 2021. It is now read-only.
LUCY-295 More Clownfish size_t adaptations#44
Merged
asfgit merged 10 commits intoapache:masterfrom Apr 27, 2016
Merged
Conversation
Adapt a few more easy-to-review transitions from uint32_t to size_t.
Cast from size_t to uint32_t to avoid -Wconversion warnings. In each of these cases, the number of elements in the Vector should be small.
The return value has been widened to size_t, so cast where necessary.
Change variable types or cast as necessary to adapt to size_t `tick` param to Vec_Fetch.
Adapt for String methods which either return size_t or accept size_t parameters.
Contributor
|
Looks good. |
asfgit
pushed a commit
that referenced
this pull request
Apr 27, 2016
Adapt Lucy code for better conformance with Clownfish APIs -- in particular, those that have changed to use size_t for element counts. This closes #44.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt Lucy code for better conformance with Clownfish APIs -- in particular, those that have changed to use size_t for element counts.