This repository was archived by the owner on May 12, 2021. It is now read-only.
LUCY-295 Adapt file position code for -Wconversion#46
Merged
asfgit merged 3 commits intoapache:masterfrom May 2, 2016
Merged
Conversation
Use int64_t rather than size_t to make overflow checking easier.
Perform casts or change variable types to make code manipulating file positions compliant with -Wconversion.
| InStream_Seek(ix_in, (int64_t)doc_id * 8); | ||
| start = InStream_Read_U64(ix_in); | ||
| InStream_Seek(ix_in, doc_id * 8); | ||
| start = InStream_Read_I64(ix_in); |
Contributor
There was a problem hiding this comment.
Isn't the cast needed to avoid overflow in the multiplication?
Contributor
Author
There was a problem hiding this comment.
Good catch -- I'll add a commit to this pull request reverting that line.
asfgit
pushed a commit
that referenced
this pull request
May 2, 2016
Perform casts or variable type conversions in code manipulating file positions in order to adapt for -Wconversion. This closes #46.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perform casts or variable type conversions in code manipulating file positions in order to adapt for -Wconversion.