Skip to content

Conversation

@khannaekta
Copy link

This PR adds support for numeric array labels when loading images. It also adds a new param LABEL_DATATYPE for the user to specify the SQL datatype of the label (for example: int, smallint, bigint etc), default being TEXT. Also, the user does not need to specify weather the dependent var column y (created in the table) is an array or not, the script figures that out based on the input.

Copy link
Contributor

@orhankislal orhankislal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khannaekta khannaekta force-pushed the image-loader-support-numeric-arrays branch from a2322e2 to 6782337 Compare May 11, 2020 18:51
@fmcquillan99
Copy link

@khannaekta Could you please update the description in the header of the script since it still says:

# The format of the image tables created will have at least 3 columns:
#     (id SERIAL, x REAL[], y).  Each row is 1 image,
#     with image data represented by x (a 3D array of type "real"), and
#     y (category) as text. 

Also could you be more explicit when describing LABEL_DATATYPE that it can be used to load numeric arrays. It does not mention arrays at all currently.

Ekta Khanna added 2 commits May 11, 2020 18:37
Prior to this commit, the image_loader assumed that the labels can only
be passed in as single values, instead of arrays. This does not hold
true for certain networks.
Add an example to the notebook for support of numeric array
@khannaekta khannaekta force-pushed the image-loader-support-numeric-arrays branch from 6782337 to 6f604c8 Compare May 12, 2020 01:38
@khannaekta khannaekta merged commit 907b479 into apache:asf-site May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants