Minibatch Preprocessing: fix dependent var with special character#273
Closed
jingyimei wants to merge 4 commits intoapache:masterfrom
Closed
Minibatch Preprocessing: fix dependent var with special character#273jingyimei wants to merge 4 commits intoapache:masterfrom
jingyimei wants to merge 4 commits intoapache:masterfrom
Conversation
JIRA:MADLIB-1237
Previously, minibatch processing would error out when the specified
dependent variable has special characters within its values. We
fixed this in two places:
1. in the query with WHERE condition, we use $$ to queto string instead
of ' ' to do string equals.
2. in the query with creating an array column, instead of using
SELECT '{ele'with*special_char, 'M,M', 'M$M'}'::text[], we call
SELECT string_to_array(''ele'with*special_char', 'M"M', 'M$M'', ',')::text[]
Install check test cases also get updated.
Co-Authored-by: Jingyi Mei <jmei@pivotal.io>
|
Refer to this link for build results (access rights to CI server needed): |
ArvindSridhar
approved these changes
May 29, 2018
Contributor
ArvindSridhar
left a comment
ArvindSridhar
left a comment
There was a problem hiding this comment.
\w @orhankislal Looks good to us
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Author
|
Will handle those in another PR, closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA:MADLIB-1237
Previously, minibatch processing would error out when the specified
dependent variable has special characters within its values. We
fixed this in two places:
of ' ' to do string equals.
SELECT '{ele'withspecial_char, 'M,M', 'M$M'}'::text[],
we call
SELECT string_to_array(''ele'withspecial_char', 'M"M', 'M$M'', ',')::text[]
Install check test cases also get updated.
Co-Authored-by: Jingyi Mei jmei@pivotal.io