Madpack: Fix various schema related bugs#297
Closed
orhankislal wants to merge 2 commits intoapache:masterfrom
Closed
Madpack: Fix various schema related bugs#297orhankislal wants to merge 2 commits intoapache:masterfrom
orhankislal wants to merge 2 commits intoapache:masterfrom
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
njayaram2
suggested changes
Jul 23, 2018
| modset = _get_modset_for_tests(testcase, 'test_') | ||
| # Loop through all modules and run unit tests | ||
| _process_py_sql_files_in_modules(modset, {'madpack_cmd':'unit-test'}) | ||
| _process_py_sql_files_in_modules(modset, {'madpack_cmd':'Unit-test'}) |
Contributor
There was a problem hiding this comment.
Changing unit-test to Unit-test causes a failure when we try to run madpack with unit-test option. It's probably because the check for madpack command in function _process_py_sql_files_in_modules is case sensitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.