Skip to content

Update Dockerfile to use ubuntu 16.04#332

Closed
jingyimei wants to merge 2 commits intoapache:masterfrom
madlib:update_dockerfile
Closed

Update Dockerfile to use ubuntu 16.04#332
jingyimei wants to merge 2 commits intoapache:masterfrom
madlib:update_dockerfile

Conversation

@jingyimei
Copy link
Copy Markdown

This commit adds a new dockerfile to bake postgres 10.5 on ubuntu
16.04. Also updates docker_start.sh and README to pull the new docker image instead
of the old one (Postgres9.6 on Ubuntu 8.9).

This commit adds a new dockerfile to bake postgres 10.5 on ubuntu
16.04. Also updates docker_start.sh and README to pull the new docker image instead
of the old one (Postgres9.6 on Ubuntu 8.9).
@asfgit
Copy link
Copy Markdown

asfgit commented Oct 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/703/

@orhankislal
Copy link
Copy Markdown
Contributor

Please do not merge this PR until we change the version to 1.16-dev.

cd ..

### Install doxygen-1.8.13:
RUN wget http://ftp.stack.nl/pub/users/dimitri/doxygen-1.8.13.src.tar.gz && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to compile doxygen if we are not going to run make doc

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make doc is optional when people want to install madlib, and that's why I removed the line make doc before. But I think it is OK to bake doxygen in the image and people can run make doc when needed.

## line 88, and run:
## docker build -t madlib/postgres_10:LaTex -f tool/docker/base/Dockerfile_ubuntu16_postgres10 .
## To push it to docker hub, run:
## docker push madlib/postgres_10:LaTex No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

### uncomment the following 'RUN apt-get' line to bake LaTex into the image
### Note: if you run the following line, please tag the image as
### madlib/postgres_10:LaTex, and don't tag it as latest
# RUN apt-get install -y texlive-full
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we have another image with the tag LaTex. Why do we need instructions for installing latex?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for making design doc (pdf). LaTex is pretty big and thus we make different images so people can pull it when needed.

@asfgit
Copy link
Copy Markdown

asfgit commented Oct 26, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/706/

@asfgit asfgit closed this in a61054c Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants