Deep Learning: Disable deep learning for gpdb 4.3 #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaknikhil
force-pushed
the
feature/disable-dl-gpdb43
branch
from
c8349c1 to
a36849e
Compare
kaknikhil
added a commit
to madlib/madlib
that referenced
this pull request
Mar 20, 2019
We won't support deep learning on gpdb 4.3 because 1. Deep learning requires the type 'JSON' which isn't supported in gpdb 4.3. 2. Our deep learning module depends on tensorflow to be pre installed. GPDB 4.3 ships with python 2.6.9 which doesn't support tensorflow. madpack currently looks for Modules.yml first in "src/ports/portid/dbver/config" and then in src/config. This commit copies the custom Modules.yml in the src/ports/portid/dbver/config/ dir. We use a custom Modules.yml file for gpdb 4.3 which is just a copy of the existing Modules.yml file. A future commit will add support for the 'deep_learning' module which will not be included in this yml. Closes apache#358 Co-authored-by: Orhan Kislal <okislal@apache.org>
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
We won't support deep learning on gpdb 4.3 because 1. Deep learning requires the type 'JSON' which isn't supported in gpdb 4.3. 2. Our deep learning module depends on tensorflow to be pre installed. GPDB 4.3 ships with python 2.6.9 which doesn't support tensorflow. madpack currently looks for Modules.yml first in "src/ports/portid/dbver/config" and then in src/config. This commit copies the custom Modules.yml in the src/ports/portid/dbver/config/ dir. We use a custom Modules.yml file for gpdb 4.3 which is just a copy of the existing Modules.yml file. A future commit will add support for the 'deep_learning' module which will not be included in this yml. Closes apache#358 Co-authored-by: Orhan Kislal <okislal@apache.org>
kaknikhil
force-pushed
the
feature/disable-dl-gpdb43
branch
from
a36849e to
cad78ac
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
njayaram2
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We won't support deep learning on gpdb 4.3 because
4.3.
GPDB 4.3 ships with python 2.6.9 which doesn't support tensorflow.
madpack currently looks for Modules.yml first in
"src/ports/portid/dbver/config" and then in src/config. This commit
copies the custom Modules.yml in the src/ports/portid/dbver/config/ dir.
We use a custom Modules.yml file for gpdb 4.3 which is just a copy of
the existing Modules.yml file.
A future commit will add support for the 'deep_learning' module which
will not be included in this yml.
Closes #358
Co-authored-by: Orhan Kislal okislal@apache.org