[MPOM-113] Missing execution ids

[jira-importer]

Christopher Tubbs opened MPOM-113 and commented

The maven-gpg-plugin and maven-remote-resources-plugin executions are missing an <id> element.

---

Affects: ASF-17

0 votes, 6 watchers

[jira-importer]

Karl Heinz Marbaise commented

If you omit the execution id it will be set to default. So not necessary to set one explicit.

[jira-importer]

Christopher Tubbs commented

May not be necessary, but I've found it to be quite helpful, especially to avoid surprises with unexpected collisions.

Should be a simple thing to add, too. Perhaps it'd be alright if we re-classify this issue as "Trivial" "Improvement" and reopen it? I'll provide a patch, too.

I wasn't aware of the default id when unspecified. Where is that documented?

[jira-importer]

Anders Hammar commented

IMO you should specify an executionId. "default" is not a good one for specific executions.

[jira-importer]

Herve Boutemy commented

I don't know if there is a little word on it in a documentation that nobody will find/read/understand

but the fact is that at runtime, Maven output displays the execution id

with Maven 2:

[INFO] [remote-resources:process {execution: default}]

with Maven 3:

[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ file-management ---

[jira-importer]

Christopher Tubbs commented

Good point. I had forgotten about those. The word "default" can mean many things, and it's not always obvious where it's coming from, so it's easy to overlook. I think a good custom name would be better for specific executions.

[jira-importer]

Anders Hammar commented

I think this ticket is valid and should be re-opened.

[jira-importer]

Herve Boutemy commented

yes, that can be a good little improvement

any idea on the id names?

[jira-importer]

Christopher Tubbs commented

Doesn't matter that much. Maybe sign-release-artifacts and process-resource-bundles?