MPOM-255 enforce setting property "project.build.outputTimestamp"

[kwin]

No description provided.

[michael-o]

Althouth this looks technically correct, I do think that this will not work. You have moved the property to a comment and added an enforcer rule, but with the next release the property will be added again and inherited.

[kwin]

IMHO maven-release-plugin will only update an existing property but never add it initially.

[michael-o]

You are right: https://github.com/apache/maven-release/blob/44ff401499713c981732f3379de2cf6693e0fdef/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java#L350-L355

[kwin]

Seems we need to disable the enforcer check for the build of asf parent itself

[michael-o]

What would be your proposal then?

[kwin]

Activate the rule only in a profile which is activated only in case a marker file with name asf-parent.marker is missing. That would require adding such a file (could be empty) to the maven-apache-parent repository.
The only other option is to deal with explicitly given profiles or system properties in case asf-parent is built.

I tried it out in kwin@aff2ed0 and it seems to work. Should I raise a follow-up PR?

[michael-o]

I think we can make the file even hidden because this is a technical detail. Please raise a followup PR for this.

[kwin]

I raised a follow-up PR in #33. @michael-o Please have a look.

[jira-importer]

Resolve #481