Reference repo should be configured according to user settings#205
Merged
slawekjaranowski merged 1 commit intoapache:masterfrom Mar 25, 2026
Merged
Conversation
We should take into account user settings like mirrors, proxies or authorizations
18b906f to
6f81951
Compare
2a543bf to
6f81951
Compare
cstamas
approved these changes
Mar 24, 2026
Member
|
can we describe a concrete setup where "take into account user settings like mirrors, proxies or authorizations" has an impact? |
Member
Author
eg, when user have configured proxy in your settings.xml it should be used |
hboutemy
approved these changes
Mar 25, 2026
Member
hboutemy
left a comment
There was a problem hiding this comment.
thanks, stupid me, I forgot MRM usage when you don't have direct access to Maven Central
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should take into account user settings like mirrors, proxies or authorizations
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.