[MCHANGES-203] Use the POMs issueManagement.system when selecting the system to use

[jira-importer]

Michael Wenig opened MCHANGES-203 and commented

We are defining the changes plugin in a corporate pom. We want to specify the url-templates there via issueLinkTemplatePerSystem.

Unfortunately for the selection of the system the poms issueTracking information seems not to be used so every project has to define the plugin and set the issueLinkTemplatePerSystem (or provide a system-attribut on every action).

Are there any reasons for not using poms project.issueTracking.system as default?

---

Affects: 2.3

[jira-importer]

Dennis Lundberg commented

I don't follow what it is you want to do. Can you provide us with some examples?

[jira-importer]

Michael Wenig commented

We want to achieve that the several projects does not need to configure the changes plugin for themselves and provide a central configuration which is used when a changes.xml is present. That is working at the moment with the exception of the links to the issue system.

In our central pom:

<plugin>
<maven-changes-plugin>
<configuration>
<issueLinkTemplatePerSystem>
<jira>%URL%/%ISSUE%</jira>
<bugzilla>%URL%/show_bug.cgi?id=%ISSUE%</bugzilla>
<....>
</issueLinkTemplatePerSystem>

in the project A pom:
<issueManagement>
<type>jira</type>
<url>...</url>
</issueManagement>
[no configuration of changes plugin]

in the project B pom:
<issueManagement>
<type>bugzilla</type>
<url>...</url>
</issueManagement>
[no configuration of changes plugin]

When generating the changes report the plugin should choose the template according to the issueManagement.type if it is not specified at the action.
Currently it uses everytime the 'default' (as there is normally no system attribute at the actions) which leads either to nonsense urls or the need to configure the plugin in every project:

projectA:
<plugin>
<maven-changes-plugin>
<configuration>
<issueLinkTemplate>%URL%/%ISSUE%</issueLinkTemplate>

projectB:
<plugin>
<maven-changes-plugin>
<configuration>
<issueLinkTemplate>%URL%/show_bug.cgi?id=%ISSUE%</issueLinkTemplate>

I hope the pain is clear now :-)

[jira-importer]

Dennis Lundberg commented

Thanks for that explanation. Now I see what you mean.

[jira-importer]

Dennis Lundberg commented

Fixed in r1054461.

The way this has been implemented may unfortunately mean that some users will need to reconfigure the plugin if they upgrade. This is because we still have to carry along some backward compatibility luggage. I have added instructions for this on the usage page. However the changes I've will make the configuration much easier to understand than before.