[MCHANGES-453] Align report output and goals names#92
Merged
slawekjaranowski merged 1 commit intomasterfrom Dec 7, 2024
Merged
[MCHANGES-453] Align report output and goals names#92slawekjaranowski merged 1 commit intomasterfrom
slawekjaranowski merged 1 commit intomasterfrom
Conversation
slawekjaranowski
force-pushed
the
MCHANGES-453
branch
from
59b2216 to
dc3495d
Compare
elharo
approved these changes
Dec 3, 2024
slawekjaranowski
force-pushed
the
MCHANGES-453
branch
from
dc3495d to
39f11b7
Compare
michael-o
reviewed
Dec 4, 2024
Member
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
One could consider to rename the external reports to: {name}-changes so they are consistent with the internal (included) approach. WDYT?
Member
Author
|
So will be ... looks ok |
Member
Yes, correct. |
slawekjaranowski
force-pushed
the
MCHANGES-453
branch
from
39f11b7 to
6e818d4
Compare
Member
Author
|
@michael-o - done |
elharo
approved these changes
Dec 4, 2024
Member
|
Maybe the Java classes should be alike, e.g., ChangesReport.java, JiraChangesReport.java, etc? |
slawekjaranowski
force-pushed
the
MCHANGES-453
branch
from
6e818d4 to
2a376bb
Compare
Member
Author
|
ok, next round of review I will add a deprecated report i next PR, I would like to preserve renaming file in git history |
slawekjaranowski
force-pushed
the
MCHANGES-453
branch
from
2a376bb to
0e74157
Compare
slawekjaranowski
force-pushed
the
MCHANGES-453
branch
from
0e74157 to
a7ca3ab
Compare
Member
Author
|
@michael-o I hope is ready |
|
Resolve #383 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MCHANGES-453