[MCLEAN-58] Maven Clean Plugin ignores followSymLinks parameter on Windows

[jira-importer]

Sergei Makarov opened MCLEAN-58 and commented

Most of old java software use getCanonicalFile() to determine symlink. But it is lie for windows. Lets look to org.apache.maven.plugin.clean.Cleaner:

147 File canonical = followSymlinks ? file : file.getCanonicalFile();
148 if ( followSymlinks || file.equals( canonical ) )

getCanonicalFile() returns same path and folow symlink. In attached MavenCleanPluginNoFollowSymlinkBug.zip you found TestCase.bat that shows bug (just read it to understand than run). Unfortunately I know only one way to fix this - move to NIO that has isSymbolicLink() since java 1.7.

---

Affects: 2.5

Attachments:

• MavenCleanPluginNoFollowSymlinkBug.zip (2.26 kB)

[jira-importer]

Kristian Rosenvold commented

Fixed for java7+ users in r1631508. This will never be supported for earlier java versions

[jira-importer]

Miłosz S commented

Please also note that on Windows there are symlinks AND "junctions":

https://docs.microsoft.com/en-us/windows/win32/fileio/hard-links-and-junctions

And java.nio.file.Files.isSymbolicLink() is not detecting junctions, same like org.apache.maven.shared.utils.io.FileUtils from maven-shared-utils. To detect them, you should check for file attributes of given Path:

Path p = Paths.get("C:\\some\\path")
BasicFileAttributes attrs = Files.readAttributes(p, BasicFileAttributes.class, LinkOption.NOFOLLOW_LINKS);
boolean isJunction = attrs.isDirectory() && attrs.isOther();

^Above solution suggested here on JDK JIRA